lkml.org 
[lkml]   [2018]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] drivers: net: wlcore: remove duplicate \n for some warnings
Date
"H. Nikolaus Schaller" <hns@goldelico.com> writes:

>> Am 25.07.2018 um 08:40 schrieb Kalle Valo <kvalo@codeaurora.org>:
>>
>> "H. Nikolaus Schaller" <hns@goldelico.com> writes:
>>
>>> wl1271_warning() already appends a \n to the format,
>>> so adding one to the warning string gives empty lines in the log.
>>>
>>> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
>>
>> "drivers: net:" in the title is unnecessary, but I can remove that.
>
> Ok, thanks! I wasn't aware of the precise subsystem tagging style here.

Yeah, subsystems can do it a bit differently. But you can easily check
with git log the preferred style:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#subject

--
Kalle Valo

\
 
 \ /
  Last update: 2018-07-25 10:41    [W:0.082 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site