Messages in this thread | | | From | Linus Torvalds <> | Date | Tue, 24 Jul 2018 10:37:56 -0700 | Subject | Re: [PATCH] media: staging: omap4iss: Include asm/cacheflush.h after generic includes |
| |
On Mon, Jul 23, 2018 at 8:41 PM Mauro Carvalho Chehab <mchehab+samsung@kernel.org> wrote: > > While I won't be against merging it, IMHO a better fix would be to > add the includes asm/cacheflush.h needs inside it, e. g. something > like adding:
No. The <asm/*> includes really should come after <linux/*>.
This is a media driver bug, plain and simple.
We should strive to avoid adding more header includes, it's one of the major causes of kernel build slowdown.
Linus
| |