Messages in this thread | | | Date | Tue, 24 Jul 2018 16:44:07 +0200 | From | Thomas Petazzoni <> | Subject | Re: [PATCH 1/2] sparc: move MSI related definitions to where they are used |
| |
Hello,
Thanks for the review.
On Tue, 24 Jul 2018 16:37:36 +0200, Sam Ravnborg wrote:
> One nitpick below. > But other than that this is a nice cleanup: > Acked-by: Sam Ravnborg <sam@ravnborg.org> > > +/* > > + * Locations of MSI Registers. > > + */ > > The SPARC way to format comments follows netdev style. > So put it all in one line and everyone are happy:
Well, the code is being moved from arch/sparc to arch/sparc, so apparently, it was already non-compliant to this specific coding style rule. Should the comments be made compliant as part of the same commit, or a separate one ?
Thomas -- Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com
| |