Messages in this thread | | | From | Daniel Drake <> | Date | Tue, 24 Jul 2018 07:29:04 -0500 | Subject | Re: [PATCH 2/2] pinctrl/amd: use byte access to clear irq/wake status bits |
| |
On Fri, Jul 20, 2018 at 6:38 PM, Daniel Kurtz <djkurtz@chromium.org> wrote: > Sounds reasonable. How about: > > - /* Clear interrupt. > - * We must read the pin register again, in case the > - * value was changed while executing > - * generic_handle_irq() above. > + /* > + * Write-1-to-clear irq/wake status bits in MSByte. > + * All other bits in this byte are read-only. > + * This avoids modifying the lower 24-bits > because they may have > + * changed while executing generic_handle_irq() above. > */
That looks good. Thanks
Daniel
| |