lkml.org 
[lkml]   [2018]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v5 1/2] mfd: rk808: Refactor shutdown functions
From
Date
Hi,

Am 16.04.2018 um 11:38 schrieb Lee Jones:
> On Thu, 29 Mar 2018, Daniel Schultz wrote:
>
>> Since all three shutdown functions have almost the same code, all logic
>> from the shutdown functions can be refactored to a new function
>> "rk808_update_bits", which can update a register by a given address and
>> bitmask.
>>
>> Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
>> ---
>> Changes:
>> v2: Re-submit with recipients from Rockchip.
>> v3: - Added devicetree property to enable the PMIC reset seperate from
>> "rockchip,system-power-controller".
>> - Dropped the first patch of this serie.
>> v4: Splitted refactoring and the new reset feature.
>> v5: Removed null pointer from rk808_update_bits.
>>
>> drivers/mfd/rk808.c | 46 +++++++++++++---------------------------------
>> 1 file changed, 13 insertions(+), 33 deletions(-)
> I'd still like an Ack/Review from the Rockchip guys please.
>
can someone from Rockchip reply to this?

\
 
 \ /
  Last update: 2018-07-24 11:50    [W:0.066 / U:1.980 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site