lkml.org 
[lkml]   [2018]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] random: Remove preempt disabled region
On Wed, Jul 11, 2018 at 04:37:21PM +0200, Sebastian Andrzej Siewior wrote:
> From: Ingo Molnar <mingo@elte.hu>
>
> No need to keep preemption disabled across the whole function.
>
> mix_pool_bytes() uses a spin_lock() to protect the pool and there are
> other places like write_pool() whhich invoke mix_pool_bytes() without
> disabling preemption.
> credit_entropy_bits() is invoked from other places like
> add_hwgenerator_randomness() without disabling preemption.
>
> Before commit 95b709b6be49 ("random: drop trickle mode") the function
> used __this_cpu_inc_return() which would require disabled preemption.
> The preempt_disable() section was added in commit 43d5d3018c37 ("[PATCH]
> random driver preempt robustness", history tree). It was claimed that
> the code relied on "vt_ioctl() being called under BKL".
>
> Cc: "Theodore Ts'o" <tytso@mit.edu>
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> [bigeasy: enhance the commit message]
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

Applied, thanks.

- Ted

\
 
 \ /
  Last update: 2018-07-22 17:24    [W:0.061 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site