lkml.org 
[lkml]   [2018]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 09/11] touchscreen: raydium_ts: Use octal permissions
    Date
    WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.
    +static DEVICE_ATTR(fw_version, S_IRUGO, raydium_i2c_fw_ver_show, NULL);

    WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.
    +static DEVICE_ATTR(hw_version, S_IRUGO, raydium_i2c_hw_ver_show, NULL);

    WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.
    +static DEVICE_ATTR(boot_mode, S_IRUGO, raydium_i2c_boot_mode_show, NULL);

    WARNING: Symbolic permissions 'S_IWUSR' are not preferred. Consider using octal permissions '0200'.
    +static DEVICE_ATTR(update_fw, S_IWUSR, NULL, raydium_i2c_update_fw_store);

    WARNING: Symbolic permissions 'S_IWUSR' are not preferred. Consider using octal permissions '0200'.
    +static DEVICE_ATTR(calibrate, S_IWUSR, NULL, raydium_i2c_calibrate_store);

    Signed-off-by: dev-harsh1998 <harshitjain6751@gmail.com>
    ---
    drivers/input/touchscreen/raydium_i2c_ts.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    diff --git a/drivers/input/touchscreen/raydium_i2c_ts.c b/drivers/input/touchscreen/raydium_i2c_ts.c
    index d1c09e6a2cb6..eddbb51e55dd 100644
    --- a/drivers/input/touchscreen/raydium_i2c_ts.c
    +++ b/drivers/input/touchscreen/raydium_i2c_ts.c
    @@ -934,9 +934,9 @@ static ssize_t raydium_i2c_calibrate_store(struct device *dev,
    return error ?: count;
    }

    -static DEVICE_ATTR(fw_version, S_IRUGO, raydium_i2c_fw_ver_show, NULL);
    -static DEVICE_ATTR(hw_version, S_IRUGO, raydium_i2c_hw_ver_show, NULL);
    -static DEVICE_ATTR(boot_mode, S_IRUGO, raydium_i2c_boot_mode_show, NULL);
    +static DEVICE_ATTR(fw_version, 0444, raydium_i2c_fw_ver_show, NULL);
    +static DEVICE_ATTR(hw_version, 0444, raydium_i2c_hw_ver_show, NULL);
    +static DEVICE_ATTR(boot_mode, 0444, raydium_i2c_boot_mode_show, NULL);
    static DEVICE_ATTR(update_fw, S_IWUSR, NULL, raydium_i2c_update_fw_store);
    static DEVICE_ATTR(calibrate, S_IWUSR, NULL, raydium_i2c_calibrate_store);

    --
    2.17.1
    \
     
     \ /
      Last update: 2018-07-21 21:11    [W:2.620 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site