Messages in this thread Patch in this message | | | From | Todd Poynor <> | Subject | [PATCH 03/14] staging: gasket: gasket_handle_ioctl fix ioctl exit trace param | Date | Sat, 21 Jul 2018 05:56:44 -0700 |
| |
From: Todd Poynor <toddpoynor@google.com>
Pass the return value from the device ioctl permissions callback to the tracepoint when the callback returns an error.
Reported-by: Dmitry Torokhov <dtor@chromium.org> Signed-off-by: Todd Poynor <toddpoynor@google.com> --- drivers/staging/gasket/gasket_ioctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gasket/gasket_ioctl.c b/drivers/staging/gasket/gasket_ioctl.c index dbe9fdef0c268..1b164ac7a0496 100644 --- a/drivers/staging/gasket/gasket_ioctl.c +++ b/drivers/staging/gasket/gasket_ioctl.c @@ -65,7 +65,7 @@ long gasket_handle_ioctl(struct file *filp, uint cmd, void __user *argp) if (ioctl_permissions_cb) { retval = ioctl_permissions_cb(filp, cmd, argp); if (retval < 0) { - trace_gasket_ioctl_exit(-EPERM); + trace_gasket_ioctl_exit(retval); return retval; } else if (retval == 0) { trace_gasket_ioctl_exit(-EPERM); -- 2.18.0.233.g985f88cf7e-goog
| |