lkml.org 
[lkml]   [2018]   [Jul]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 1/2] arm64: dts: qcom: pm8998: Add spmi-temp-alarm node
Hi,

On Mon, Jul 2, 2018 at 1:51 PM, Matthias Kaehlcke <mka@chromium.org> wrote:
>> > + compatible = "qcom,spmi-temp-alarm";
>> > + reg = <0x2400 0x100>;
>>
>> Why are there two numbers for the "reg"? Should just be 0x2400.
>
> From /Documentation/devicetree/bindings/thermal/qcom-spmi-temp-alarm.txt:
>
> Required properties:
> ...
> - reg: Specifies the SPMI address and length of the controller's
> registers.

Hrm, something isn't adding up here.

A) Do a "git grep" and you'll see that nobody else has the length.

$ git grep -C2 -- qcom,spmi-temp-alarm | grep reg

arch/arm/boot/dts/qcom-pm8841.dtsi- reg = <0x2400>;
arch/arm/boot/dts/qcom-pm8941.dtsi- reg = <0x2400>;
arch/arm/boot/dts/qcom-pma8084.dtsi- reg = <0x2400>;
arch/arm64/boot/dts/qcom/pm8916.dtsi- reg = <0x2400>;

---

B) The SPMI bus you're adding it to has "#size-cells = <0>;" ...as do
all other SPMI busses:

$ git grep -C5 qcom,spmi-pmic | grep size-cells
arch/arm/boot/dts/qcom-pm8841.dtsi- #size-cells = <0>;
arch/arm/boot/dts/qcom-pm8841.dtsi- #size-cells = <0>;
arch/arm/boot/dts/qcom-pm8941.dtsi- #size-cells = <0>;
arch/arm/boot/dts/qcom-pm8941.dtsi- #size-cells = <0>;
arch/arm/boot/dts/qcom-pma8084.dtsi- #size-cells = <0>;
arch/arm/boot/dts/qcom-pma8084.dtsi- #size-cells = <0>;
arch/arm64/boot/dts/qcom/pm8004.dtsi- #size-cells = <0>;
arch/arm64/boot/dts/qcom/pm8004.dtsi- #size-cells = <0>;
arch/arm64/boot/dts/qcom/pm8005.dtsi- #size-cells = <0>;
arch/arm64/boot/dts/qcom/pm8005.dtsi- #size-cells = <0>;
arch/arm64/boot/dts/qcom/pm8916.dtsi- #size-cells = <0>;
arch/arm64/boot/dts/qcom/pm8916.dtsi- #size-cells = <0>;
arch/arm64/boot/dts/qcom/pm8994.dtsi- #size-cells = <0>;
arch/arm64/boot/dts/qcom/pm8994.dtsi- #size-cells = <0>;
arch/arm64/boot/dts/qcom/pm8998.dtsi- #size-cells = <0>;
arch/arm64/boot/dts/qcom/pm8998.dtsi- #size-cells = <0>;
arch/arm64/boot/dts/qcom/pmi8994.dtsi- #size-cells = <0>;
arch/arm64/boot/dts/qcom/pmi8994.dtsi- #size-cells = <0>;

...I have no SPMI history, but my guess is that upstream dropped this
because all SPMI devices have 256-byte regions (see
qcom,spmi-pmic.txt)?


So probably the right thing is to fix the qcom,spmi-temp-alarm not to
have the size...

-Doug

\
 
 \ /
  Last update: 2018-07-02 23:04    [W:0.641 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site