lkml.org 
[lkml]   [2018]   [Jul]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] venus: venc: add support for ext controls
Hi Vikash,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.18-rc3 next-20180702]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Vikash-Garodia/venus-venc-add-support-for-ext-controls/20180702-213140
base: git://linuxtv.org/media_tree.git master
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 8.1.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=8.1.0 make.cross ARCH=ia64

All errors (new ones prefixed by >>):

drivers/media/platform/qcom/venus/venc.c:653:3: error: 'const struct v4l2_ioctl_ops' has no member named 'vidioc_s_ext_ctrl'; did you mean 'vidioc_s_ext_ctrls'?
.vidioc_s_ext_ctrl = venc_s_ext_ctrls,
^~~~~~~~~~~~~~~~~
vidioc_s_ext_ctrls
>> drivers/media/platform/qcom/venus/venc.c:653:23: error: initialization of 'int (*)(struct file *, void *, struct v4l2_streamparm *)' from incompatible pointer type 'int (*)(struct file *, void *, struct v4l2_ext_controls *)' [-Werror=incompatible-pointer-types]
.vidioc_s_ext_ctrl = venc_s_ext_ctrls,
^~~~~~~~~~~~~~~~
drivers/media/platform/qcom/venus/venc.c:653:23: note: (near initialization for 'venc_ioctl_ops.vidioc_s_parm')
cc1: some warnings being treated as errors

vim +653 drivers/media/platform/qcom/venus/venc.c

629
630 static const struct v4l2_ioctl_ops venc_ioctl_ops = {
631 .vidioc_querycap = venc_querycap,
632 .vidioc_enum_fmt_vid_cap_mplane = venc_enum_fmt,
633 .vidioc_enum_fmt_vid_out_mplane = venc_enum_fmt,
634 .vidioc_s_fmt_vid_cap_mplane = venc_s_fmt,
635 .vidioc_s_fmt_vid_out_mplane = venc_s_fmt,
636 .vidioc_g_fmt_vid_cap_mplane = venc_g_fmt,
637 .vidioc_g_fmt_vid_out_mplane = venc_g_fmt,
638 .vidioc_try_fmt_vid_cap_mplane = venc_try_fmt,
639 .vidioc_try_fmt_vid_out_mplane = venc_try_fmt,
640 .vidioc_g_selection = venc_g_selection,
641 .vidioc_s_selection = venc_s_selection,
642 .vidioc_reqbufs = v4l2_m2m_ioctl_reqbufs,
643 .vidioc_querybuf = v4l2_m2m_ioctl_querybuf,
644 .vidioc_create_bufs = v4l2_m2m_ioctl_create_bufs,
645 .vidioc_prepare_buf = v4l2_m2m_ioctl_prepare_buf,
646 .vidioc_qbuf = v4l2_m2m_ioctl_qbuf,
647 .vidioc_expbuf = v4l2_m2m_ioctl_expbuf,
648 .vidioc_dqbuf = v4l2_m2m_ioctl_dqbuf,
649 .vidioc_streamon = v4l2_m2m_ioctl_streamon,
650 .vidioc_streamoff = v4l2_m2m_ioctl_streamoff,
651 .vidioc_s_parm = venc_s_parm,
652 .vidioc_g_parm = venc_g_parm,
> 653 .vidioc_s_ext_ctrl = venc_s_ext_ctrls,
654 .vidioc_enum_framesizes = venc_enum_framesizes,
655 .vidioc_enum_frameintervals = venc_enum_frameintervals,
656 .vidioc_subscribe_event = v4l2_ctrl_subscribe_event,
657 .vidioc_unsubscribe_event = v4l2_event_unsubscribe,
658 };
659

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2018-07-02 19:02    [W:0.159 / U:0.784 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site