Messages in this thread | | | Subject | Re: [PATCH] net: stmmac_tc: use 64-bit arithmetic instead of 32-bit | From | Jose Abreu <> | Date | Mon, 2 Jul 2018 16:19:23 +0100 |
| |
On 02-07-2018 13:09, Gustavo A. R. Silva wrote: > Add suffix UL to constant 1024 in order to give the compiler complete > information about the proper arithmetic to use. Notice that this > constant is used in a context that expects an expression of type > u64 (64 bits, unsigned) and following expressions are currently > being evaluated using 32-bit arithmetic: > > qopt->idleslope * 1024 * ptr > qopt->hicredit * 1024 * 8 > qopt->locredit * 1024 * 8 > > Addresses-Coverity-ID: 1470246 ("Unintentional integer overflow") > Addresses-Coverity-ID: 1470248 ("Unintentional integer overflow") > Addresses-Coverity-ID: 1470249 ("Unintentional integer overflow") > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> >
Acked-by: Jose Abreu <joabreu@synopsys.com>
Thanks!
Best Regards, Jose Miguel Abreu
| |