Messages in this thread | | | From | Linus Walleij <> | Date | Mon, 2 Jul 2018 16:06:02 +0200 | Subject | Re: [PATCH][V2] pinctrl: actions: fix unsigned less than zero comparison |
| |
On Mon, Jul 2, 2018 at 2:47 PM Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com> > > The check to see if platform_get_irq failed is performed on the > unsigned value of pctrl->irq[i] and the check is never true because > an unsigned cannot be less than zero. Fix this by assinging the > signed int ret to the return of platform_get_irq and checking ret > instead. > > Detected by CoverityScan, CID#1470247 ("Unsigned comparison against 0") > > Fixes: 6c5d0736e9c0 ("pinctrl: actions: Add interrupt support for OWL S900 SoC") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > > V2: move pctrl->irq[i] = ret assignment below the check on ret, thanks > to Manivannan Sadhasivam for suggesting this change.
Patch applied with Manivannan's ACK!
(Hope it's the right version now.)
Yours, Linus Walleij
| |