Messages in this thread | | | Subject | Re: [PATCH] fbcon: introduce for_each_registered_fb() helper | From | Andy Shevchenko <> | Date | Mon, 02 Jul 2018 13:15:09 +0300 |
| |
On Mon, 2018-07-02 at 09:36 +0200, Bernd Petrovitsch wrote:
> > +#define for_each_registered_fb(i) \ > > + for (i = 0; i < FB_MAX; i++) \ > > + if (registered_fb[i]) > > + > > That leaves the possibility of a dangling-else. > ---- snip ---- > #define for_each_registered_fb(i) \ > for (i = 0; i < FB_MAX; i++) \ > if (!registered_fb[i]) \ > continue; \ > else > ---- snip ---- > avoids that.
Yes, you not alone :-)
AFAIU there is a v2 which fixes that, though Daniel pointed out that DRM has a specific macro to make life easier.
-- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy
| |