Messages in this thread | | | Subject | Re: [PATCH] mm: Cleanup in do_shrink_slab() | From | Kirill Tkhai <> | Date | Thu, 19 Jul 2018 19:27:48 +0300 |
| |
On 19.07.2018 19:21, David Laight wrote: > From: Kirill Tkhai >> Sent: 19 July 2018 17:05 >> >> Group long variables together to minimize number of occupied lines >> and place all definitions in back Christmas tree order. > > Grouping together unrelated variables doesn't really make the code > any more readable. > IMHO One variable per line is usually best.
>> Also, simplify expression around batch_size: use all power of C language! > > foo = bar ? : baz; > Is not part of C, it is a gcc extension.
Then, use all power of GNU extensions.
| |