lkml.org 
[lkml]   [2018]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] mm: Cleanup in do_shrink_slab()
From
Date
On 19.07.2018 19:21, David Laight wrote:
> From: Kirill Tkhai
>> Sent: 19 July 2018 17:05
>>
>> Group long variables together to minimize number of occupied lines
>> and place all definitions in back Christmas tree order.
>
> Grouping together unrelated variables doesn't really make the code
> any more readable.
> IMHO One variable per line is usually best.

>> Also, simplify expression around batch_size: use all power of C language!
>
> foo = bar ? : baz;
> Is not part of C, it is a gcc extension.

Then, use all power of GNU extensions.

\
 
 \ /
  Last update: 2018-07-19 18:28    [W:0.055 / U:0.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site