Messages in this thread | | | From | Camelia Alexandra Groza <> | Subject | RE: [PATCH] net: phy: use generic clause 45 autonegotiation done | Date | Thu, 19 Jul 2018 12:47:18 +0000 |
| |
> -----Original Message----- > From: Andrew Lunn [mailto:andrew@lunn.ch] > Sent: Wednesday, July 18, 2018 17:39 > To: Camelia Alexandra Groza <camelia.groza@nxp.com> > Cc: f.fainelli@gmail.com; davem@davemloft.net; netdev@vger.kernel.org; > linux-kernel@vger.kernel.org > Subject: Re: [PATCH] net: phy: use generic clause 45 autonegotiation done > > On Wed, Jul 18, 2018 at 04:12:15PM +0300, Camelia Groza wrote: > > Only Clause 22 PHYs can use genphy_aneg_done(). Use > > genphy_c45_aneg_done() for PHYs that implement Clause 45 without the > > Clause 22 register set. > > > > This change follows the model of phy_restart_aneg() which > > differentiates between the two implementations in a similar way. > > Hi Camelia > > What about phy_config_aneg()? I would assume any sort of auto-neg action > needs to check for c45 without c22, before calling a genphy_ function. Do you > think it is possible to write a genphy_c45_config_aneg()? If not, we might > want to return -EOPNOTSUPP.
Hi Andrew,
Adding Russell to the thread as well, since he wrote the c45 helpers.
Sure, I'll send a v2 with an additional generic phy_config_aneg(). I'll stick to returning -EOPNOTSUPP for c22-less PHYs for now.
Thanks, Camelia
| |