Messages in this thread | | | From | Arnd Bergmann <> | Date | Thu, 19 Jul 2018 10:50:12 +0200 | Subject | Re: [PATCH 4/5] crypto: Add IV generation templates |
| |
On Thu, Jul 19, 2018 at 3:46 AM, Xiongfeng Wang <wangxiongfeng2@huawei.com> wrote: > Hi, > > On 2018/7/19 1:17, Milan Broz wrote: >> On 18/07/18 18:46, Mark Brown wrote: >>> On Wed, Jul 18, 2018 at 10:16:05AM +0200, Milan Broz wrote: >>> >>>> So we are here again and moving INTERNAL dm-crypt functionality into >>>> cryptoapi. >> >> 2) If the reason is performance, please provide numbers with the patch. >> What I see now is that the performance is almost the same. So why you are doing it? >> Any real hw that benefits from it? > > Because the internal implementation of the IV template 'benbi()' is still > dividing the whole bio into sectors, so the performance is almost the same. > The purpose of this patch is to let dm-crypt rely on the new algorithm 'aes-cbc-benbi' > and pass the whole bio to the new algorithm. > And then if the hardware driver implements this new algorithm, it can get the data of > the bio at one time, and return the processed data at one time. > I think it will decrease the overhead of passing each sector alternatively. > But the hardware need to implement the new algorithm if it want to benefit from this.
There seems to be some support for at least essiv(aes) in drivers/crypto/ccree/cc_cipher.c, is that compatible with your essiv(*) template, or is that something else?
Arnd
| |