Messages in this thread | | | Subject | Re: [PATCH] pktcdvd:checkpatch:fix pointer declaration | From | Joe Perches <> | Date | Wed, 18 Jul 2018 11:43:11 -0700 |
| |
On Wed, 2018-07-18 at 18:06 +0000, Bart Van Assche wrote: > On Wed, 2018-07-18 at 21:28 +0530, RAGHU Halharvi wrote: > > * Fix all pointer declaration which causes > > "ERROR: "foo* bar" should be "foo *bar"" > > Hello Raghu, > > If you would not be aware of this, checkpatch is a tool that is intended to > verify patches before submission and not to verify code that is already > upstream. A detailed explanation of why patches like this one should not be > submitted is available in "A quick guide to why stand-alone checkpatch > patches suck" > (https://lists.kernelnewbies.org/pipermail/kernelnewbies/2014-September/012296.html).
Read more of the whole thread. Varying opinions exist.
| |