Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Wed, 18 Jul 2018 13:36:52 +0200 | Subject | Re: [PATCH 2/3] [v2] m68k: mac: use time64_t in RTC handling |
| |
On Tue, Jun 19, 2018 at 4:04 PM Arnd Bergmann <arnd@arndb.de> wrote: > The real-time clock on m68k (and powerpc) mac systems uses an unsigned > 32-bit value starting in 1904, which overflows in 2040, about two years > later than everyone else, but this gets wrapped around in the Linux > code in 2038 already because of the deprecated usage of time_t and/or > long in the conversion. > > Getting rid of the deprecated interfaces makes it work until 2040 as > documented, and it could be easily extended by reinterpreting > the resulting time64_t as a positive number. For the moment, I'm > adding a WARN_ON() that triggers if we encounter a time before 1970 > or after 2040 (the two are indistinguishable). > > This brings it in line with the corresponding code that we have on > powerpc macintosh. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks for your patch!
Applied and queued for v4.19, with the WARN_ON() dropped.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |