Messages in this thread | | | From | Andrey Smirnov <> | Date | Wed, 18 Jul 2018 17:51:08 -0700 | Subject | Re: [PATCH] ARM: dts: vf610: Add ZII SSMB SPU3 board |
| |
On Wed, Jul 18, 2018 at 3:50 PM Fabio Estevam <festevam@gmail.com> wrote: > > Hi Andrey, > > On Tue, Jul 17, 2018 at 1:06 AM, Andrey Smirnov > <andrew.smirnov@gmail.com> wrote: > > > +/dts-v1/; > > +#include "vf610.dtsi" > > + > > +/ { > > + model = "ZII VF610 SSMB SPU3 Board"; > > + compatible = "zii,vf610spu3", "zii,vf610dev", "fsl,vf610"; > > Looks good to me. > > Just a minor comment: Is " "zii,vf610dev" really needed here? >
It's not used in Linux, but I do rely on it in Barebox here:
https://git.pengutronix.de/cgit/barebox/tree/arch/arm/boards/zii-vf610-dev/board.c#n94
and here:
https://git.pengutronix.de/cgit/barebox/tree/arch/arm/boards/zii-vf610-dev/board.c#n137
so it's pretty handy to have. I can remove it if it is too much of an eyesore.
Thanks, Andrey Smirnov
| |