lkml.org 
[lkml]   [2018]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] ipv6: sr: fix useless rol32 call on hash
From
Date
On 07/17/2018 04:52 PM, Colin King wrote:
> From: Colin Ian King<colin.king@canonical.com>
>
> The rol32 call is currently rotating hash but the rol'd value is
> being discarded. I believe the current code is incorrect and hash
> should be assigned the rotated value returned from rol32.
>
> Detected by CoverityScan, CID#1468411 ("Useless call")
>
> Fixes: b5facfdba14c ("ipv6: sr: Compute flowlabel for outer IPv6 header of seg6 encap mode")
> Signed-off-by: Colin Ian King<colin.king@canonical.com>

Acked-by: dlebrun@google.com

Good catch, thanks !

In that case, the same issue is present in
include/net/ipv6.h:ip6_make_flowlabel().

\
 
 \ /
  Last update: 2018-07-17 18:03    [W:0.044 / U:2.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site