Messages in this thread | | | Subject | Re: [net-next, 2/3] tcp: convert icsk_user_timeout from jiffies to msecs | From | Eric Dumazet <> | Date | Mon, 16 Jul 2018 08:58:24 -0700 |
| |
On 07/12/2018 05:02 PM, Jon Maxwell wrote: > Create a seperate helper routine called tcp_retransmit_stamp() as per Neal > Cardwells suggestion. To be used by the final commit in this series and > retransmits_timed_out(). > > Signed-off-by: Jon Maxwell <jmaxwell37@gmail.com> > --- > net/ipv4/tcp_timer.c | 25 +++++++++++++++++-------- > 1 file changed, 17 insertions(+), 8 deletions(-) > > diff --git a/net/ipv4/tcp_timer.c b/net/ipv4/tcp_timer.c > index fa34984d0b12..8ab8c9645294 100644 > --- a/net/ipv4/tcp_timer.c > +++ b/net/ipv4/tcp_timer.c > @@ -22,6 +22,20 @@ > #include <linux/gfp.h> > #include <net/tcp.h> > > +u32 tcp_retransmit_stamp(const struct sock *sk) > +{ > + u32 start_ts = tcp_sk(sk)->retrans_stamp; > + > + if (unlikely(!start_ts)) { > + struct sk_buff *head = tcp_rtx_queue_head(sk); > + > + if (!head) > + return 0; > + start_ts = tcp_skb_timestamp(head); > + }?
Indentation is fuzzy.
Can you send a new version, with a cover letter ?
git format-patch -o ../output --cover-letter --subject-prefix "PATCH net-next" origin
...
Thanks !
| |