Messages in this thread | | | Subject | Re: [PATCH] kernel.h: Add for_each_if() | From | Randy Dunlap <> | Date | Mon, 16 Jul 2018 08:41:15 -0700 |
| |
On 07/16/2018 01:11 AM, Andy Shevchenko wrote: > On Fri, 2018-07-13 at 16:42 -0700, Randy Dunlap wrote: >> On 07/13/2018 04:37 PM, NeilBrown wrote: > >> >> coding-style.rst says: >> Also, use braces when a loop contains more than a single simple >> statement: > > Independently on a) would we use some macro for condition, or b) fix > macros against this kind of nested conditions, there is another > weirdness we would like to avoid, i.e. > > for_each_foo() { > ... > } else { > ... > } > > It is written according to coding style, but too much weird.
Yeah, that's odd. Looks like else matches the for loop. (!)
> So, summarize this discussion I think we would > - keep for_each_if() in DRM subsystem alone > - fix macros which are using positive condition 'if (cond)' by replacing > with 'if (!cond) {} else' form for sake of robustness. > > Do you agree on that?
Sure, both of those sound good to me.
thanks, -- ~Randy
| |