lkml.org 
[lkml]   [2018]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 5/5] x86/pti: constify address parameters
From
Date
On 07/15/2018 09:03 PM, Jiang Biao wrote:
> -static p4d_t *pti_user_pagetable_walk_p4d(unsigned long address)
> +static p4d_t *pti_user_pagetable_walk_p4d(const unsigned long address)
> {
> pgd_t *pgd = kernel_to_user_pgdp(pgd_offset_k(address));
> gfp_t gfp = (GFP_KERNEL | __GFP_NOTRACK | __GFP_ZERO);

I'm also a bit ambivalent on this one. While this is _correct_ and not
something I think we actively discourage, it's not something that we're
horribly diligent about doing universally in the kernel.

\
 
 \ /
  Last update: 2018-07-16 16:39    [W:0.136 / U:0.464 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site