Messages in this thread | | | From | Kevin Hilman <> | Subject | Re: [PATCH 3/3] clk: meson-g12a: Add EE Clock controller driver | Date | Mon, 16 Jul 2018 08:41:35 -0500 |
| |
Jian Hu <jian.hu@amlogic.com> writes:
> On 2018/7/10 5:53, Martin Blumenstingl wrote: >> On Mon, Jul 9, 2018 at 1:14 PM Jian Hu <jian.hu@amlogic.com> wrote:
[...]
>>> +static const struct of_device_id clkc_match_table[] = { >>> + { .compatible = "amlogic,g12a-clkc" }, >> I wonder if that should be "amlogic,meson-g12a-clkc" (I know that AXG >> and GXBB/GXL/GXM omit the "meson-" prefix, but I am not sure if that's >> correct - I'll CC Rob Herring on the dt-bindings patch) >> > For clock drivers,they omit the "meson-" prefix, But for common > amlogic drivers use "amlogic.meson-<chip>-<ip>". > So which type should we choose? .compatible = "amlogic,g12a-clkc or > > .compatible = "amlogic,meson-g12a-clkc
Please follow the existing pattern for clock drivers, omitting the "meson-" prefix.
Kevin
| |