Messages in this thread | | | Date | Mon, 16 Jul 2018 10:40:20 +0200 | From | Greg KH <> | Subject | Re: staging:rtl8192u: [0/10] Coding style changes. |
| |
On Fri, Jul 13, 2018 at 09:12:37PM +0100, John Whitmore wrote: > All coding style changes, but the second [2/10] is a bit more hairy then > most. The original code combined two typedef declarations into one with both > the structure and a pointer to the structure defined. I've totally removed the > pointer to the structure type since it uses Hungarian notation, which the > coding standard isn't keen on. > > As a result of this there are changes in code from the type: > PStructType *ppname; > to: > struct StructType **ppname; > > To keep the diff simple I've kept the current nameing of "ppname", which again > is Hungarian notation. I'll leave that for a future patch.
Nit, your subject should look like:
Subject: [PATCH 00/10] staging:rtl8192u: Coding style changes.
What are you using to generate this email? git format-patch --cover-letter should generate it with a correct subject line prefix, right?
thanks,
greg k-h
| |