Messages in this thread | | | Date | Mon, 16 Jul 2018 10:37:20 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH] pwm-omap: handle timers not ready in probe |
| |
On Mon 2018-07-16 00:57:40, Tony Lindgren wrote: > * Pavel Machek <pavel@ucw.cz> [180716 07:16]: > > > > When all the drivers are built-in, timers are not ready and probing > > fails. Fix that with -EPROBE_DEFFER. > > > > Signed-off-by: Pavel Machek <pavel@ucw.cz> > > > > diff --git a/drivers/pwm/pwm-omap-dmtimer.c b/drivers/pwm/pwm-omap-dmtimer.c > > index 665da3c..debeb70 100644 > > --- a/drivers/pwm/pwm-omap-dmtimer.c > > +++ b/drivers/pwm/pwm-omap-dmtimer.c > > @@ -265,7 +271,7 @@ static int pwm_omap_dmtimer_probe(struct platform_device *pdev) > > timer_pdata = dev_get_platdata(&timer_pdev->dev); > > if (!timer_pdata) { > > dev_err(&pdev->dev, "dmtimer pdata structure NULL\n"); > > - ret = -EINVAL; > > + ret = -EPROBE_DEFER; > > goto put; > > } > > There seems to be an earlier similar patch, care to take a look > at "[PATCH] pwm: pwm-omap-dmtimer: return -EPROBE_DEFER if no > dmtimer platform data"?
Yes, that one is equivalent.
You can add
Acked-by: Pavel Machek <pavel@ucw.cz> Tested-by: Pavel Machek <pavel@ucw.cz>
on it.
Thanks, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] | |