Messages in this thread | | | Date | Mon, 16 Jul 2018 09:25:16 +0200 | From | Marco Felsch <> | Subject | Re: [PATCH v2 1/3] dt-bindings: pfuze100: add optional disable switch-regulators binding |
| |
Hi Mark,
thanks for the review.
On 18-07-13 16:03, Mark Brown wrote: > On Fri, Jul 13, 2018 at 02:50:01PM +0200, Marco Felsch wrote: > > > +Optional properties: > > +- fsl,pfuze-support-disable: Boolean, if present disable all unused switch > > + regulators to save power consumption. Attention, till 4.18 these regulators > > The property name sounds like it affects all the regulators but really > it's just the sw ones - how about adding -sw at the end? Bit of a > bikeshed but it does end up in an ABI.
You're right, it sounds better. So the new binding will be fsl,pfuze-support-disable-sw. Are there any other comments about the implementation?
Regards, Marco
| |