Messages in this thread | | | Date | Mon, 16 Jul 2018 13:22:04 -0700 | From | Joel Fernandes <> | Subject | Re: [PATCH] staging: android: ashmem: Shrink directly through shmem_fallocate |
| |
On Mon, Jul 16, 2018 at 11:48:51AM +0200, Greg Kroah-Hartman wrote: > On Fri, Jul 06, 2018 at 02:44:16PM -0700, Joel Fernandes wrote: > > From: Tobias Lindskog <tobias.lindskog@sonymobile.com> > > > > When ashmem_shrink is called from direct reclaim on a user thread, a > > call to do_fallocate will check for permissions against the security > > policy of that user thread. It can thus fail by chance if called on a > > thread that isn't permitted to modify the relevant ashmem areas. > > > > Because we know that we have a shmem file underneath, call the shmem > > implementation of fallocate directly instead of going through the > > user-space interface for fallocate. > > > > Bug: 21951515 > > What does this "Bug:" line mean to any of us? :)
Yeah I should have been more careful when sending Tobias's patch ;-)
> I'll go delete it, and I fixed up the subject to have 'staging: android' > in it as well. Please do that next time.
Sure will do, thanks for fixing it up this time. Sorry about that.
Regards,
-Joel
| |