Messages in this thread Patch in this message | | | From | Marco Felsch <> | Subject | [PATCH] regulator: core: fix _regulator_do_disable return value | Date | Fri, 13 Jul 2018 14:56:24 +0200 |
| |
Currently _regulator_do_disable returns 0 if either the ena_pin nor the ops.disbale() isn't present. This assumes that the call was successful but it wasn't because disbaling isn't supported at all.
The last case of the if-chain should return -EINVAL, because disabling isn't supported by the driver as it is done already by _regulator_do_enable.
Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> --- drivers/regulator/core.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index bb1324f93143..69b4e096b632 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -2311,6 +2311,8 @@ static int _regulator_do_disable(struct regulator_dev *rdev) ret = rdev->desc->ops->disable(rdev); if (ret != 0) return ret; + } else { + return -EINVAL; } /* cares about last_off_jiffy only if off_on_delay is required by -- 2.18.0
| |