Messages in this thread | | | Date | Thu, 12 Jul 2018 18:01:25 +0100 | From | Will Deacon <> | Subject | Re: [PATCHv2] refcount: always allow checked forms |
| |
On Wed, Jul 11, 2018 at 10:36:07AM +0100, Mark Rutland wrote: > In many cases, it would be useful to be able to use the full > sanity-checked refcount helpers regardless of CONFIG_REFCOUNT_FULL, as > this would help to avoid duplicate warnings where callers try to > sanity-check refcount manipulation. > > This patch refactors things such that the full refcount helpers were > always built, as refcount_${op}_checked(), such that they can be used > regardless of CONFIG_REFCOUNT_FULL. This will allow code which *always* > wants a checked refcount to opt-in, avoiding the need to duplicate the > logic for warnings. > > There should be no functional change as a result of this patch. > > Signed-off-by: Mark Rutland <mark.rutland@arm.com> > Acked-by: Kees Cook <keescook@chromium.org> > Reviewed-by: David Sterba <dsterba@suse.com> > Cc: Boqun Feng <boqun.feng@gmail.com> > Cc: Ingo Molnar <mingo@kernel.org> > Cc: Peter Zijlstra <peterz@infradead.org> > Cc: Will Deacon <will.deacon@arm.com> > --- > include/linux/refcount.h | 27 +++++++++++++++++------- > lib/refcount.c | 53 +++++++++++++++++++++++------------------------- > 2 files changed, 45 insertions(+), 35 deletions(-)
Looks good to me:
Acked-by: Will Deacon <will.deacon@arm.com>
Will
| |