lkml.org 
[lkml]   [2018]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH v2 25/27] x86/cet: Add PTRACE interface for CET

* Yu-cheng Yu <yu-cheng.yu@intel.com> wrote:

> > > diff --git a/arch/x86/kernel/ptrace.c b/arch/x86/kernel/ptrace.c
> > > index e2ee403865eb..ac2bc3a18427 100644
> > > --- a/arch/x86/kernel/ptrace.c
> > > +++ b/arch/x86/kernel/ptrace.c
> > > @@ -49,7 +49,9 @@ enum x86_regset {
> > >   REGSET_IOPERM64 = REGSET_XFP,
> > >   REGSET_XSTATE,
> > >   REGSET_TLS,
> > > + REGSET_CET64 = REGSET_TLS,
> > >   REGSET_IOPERM32,
> > > + REGSET_CET32,
> > >  };
> > Why does REGSET_CET64 alias on REGSET_TLS?
>
> In x86_64_regsets[], there is no [REGSET_TLS].  The core dump code
> cannot handle holes in the array.

Is there a fundamental (ABI) reason for that?

> > to "CET" (which is a well-known acronym for "Central European Time"),
> > not to CFE?
> >
>
> I don't know if I can change that, will find out.

So what I'd suggest is something pretty simple: to use CFT/cft in kernel internal
names, except for the Intel feature bit and any MSR enumeration which can be CET
if Intel named it that way, and a short comment explaining the acronym difference.

Or something like that.

Thanks,

Ingo
\
 
 \ /
  Last update: 2018-07-15 22:06    [W:0.155 / U:38.340 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site