lkml.org 
[lkml]   [2018]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2] checkpatch: Warn if missing author Signed-off-by
Hi Joe,

On Wed, Jul 11, 2018 at 7:24 PM Joe Perches <joe@perches.com> wrote:
> On Wed, 2018-07-11 at 19:07 +0200, Geert Uytterhoeven wrote:
> > On Wed, Jul 11, 2018 at 6:20 PM Joe Perches <joe@perches.com> wrote:
> > > On Wed, 2018-07-11 at 17:10 +0200, Geert Uytterhoeven wrote:
> > > > Print a warning if none of the Signed-off-by lines cover the patch
> > > > author.
> > > >
> > > > Non-ASCII quoted printable encoding in From: headers and (lack of)
> > > > double quotes are handled.
> > > > Split From: headers are not fully handled: only the first part is
> > > > compared.
> > >
> > > []
> > > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > >
> > > []
> > > > +# Check the patch for a From:
> > > > + if (decode("MIME-Header", $line) =~ /^From:\s*(.*)/) {
> > > > + $author = encode("utf8", $1);
> > > > + $author =~ s/"//g;
> > > > + }
> > > > +
> > > > # Check the patch for a signoff:
> > > > if ($line =~ /^\s*signed-off-by:/i) {
> > > > $signoff++;
> > > > $in_commit_log = 0;
> > > > + if ($author ne '') {
> > > > + my $l = $line;
> > > > + $l =~ s/"//g;
> > > > + if ($l =~ /^\s*signed-off-by: \Q$author\E/i) {
>
> if (/^\s*signed-off-by:\s*\Q$author\E/i)

Dropping the "$l =~" doesn't fly.
The "\s*" part does work.

> > > > + $authorsignoff = 1;
> > > > + }
> > > > + }
> > > > }
> > >
> > > I don't see the point of removing the quotes.
> >
> > If the name contains a dot (e.g. "David S. Miller"), it must be protected
> > by double quotes in the From: email header, but that is usually not the case
> > in the Sob line.
>
> Right.
> It seems it's unusual for SOBs to use quotes around names.

But it does happen from time to time.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
\
 
 \ /
  Last update: 2018-07-15 22:05    [W:0.046 / U:0.520 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site