lkml.org 
[lkml]   [2018]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v4 13/14] rxrpc: Prepare to remove VLA usage for SKCIPHER_REQUEST_ON_STACK
    Date
    Two uses of SKCIPHER_REQUEST_ON_STACK() will trigger FRAME_WARN warnings
    (when less than 2048) once the VLA is no longer hidden from the check:

    net/rxrpc/rxkad.c:398:1: warning: the frame size of 1152 bytes is larger than 1024 bytes [-Wframe-larger-than=]
    net/rxrpc/rxkad.c:242:1: warning: the frame size of 1152 bytes is larger than 1024 bytes [-Wframe-larger-than=]

    This bumps the affected objects by 20% to silence the warnings while
    still providing coverage is anything grows even more.

    Signed-off-by: Kees Cook <keescook@chromium.org>
    ---
    net/rxrpc/Makefile | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/net/rxrpc/Makefile b/net/rxrpc/Makefile
    index 6ffb7e9887ce..53e1177129e6 100644
    --- a/net/rxrpc/Makefile
    +++ b/net/rxrpc/Makefile
    @@ -32,4 +32,5 @@ rxrpc-y := \

    rxrpc-$(CONFIG_PROC_FS) += proc.o
    rxrpc-$(CONFIG_RXKAD) += rxkad.o
    +CFLAGS_rxkad.o += $(FRAME_WARN_BUMP_FLAG)
    rxrpc-$(CONFIG_SYSCTL) += sysctl.o
    --
    2.17.1
    \
     
     \ /
      Last update: 2018-07-15 22:05    [W:4.091 / U:0.436 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site