lkml.org 
[lkml]   [2018]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v6 1/1] PCI: kirin: Add MSI support
On Wed, Jul 11, 2018 at 9:57 AM, Xiaowei Song <songxiaowei@hisilicon.com> wrote:
> Add support for MSI

> +static int kirin_pcie_add_msi(struct dw_pcie *pci,
> + struct platform_device *pdev)
> +{
> + int ret = 0;
> +
> + if (IS_ENABLED(CONFIG_PCI_MSI)) {
> + ret = platform_get_irq(pdev, 0);
> + if (ret < 0) {
> + dev_err(&pdev->dev,
> + "failed to get MSI IRQ (%d)\n", ret);
> + return ret;
> + }
> +
> + pci->pp.msi_irq = ret;
> + }
> +
> + return ret;
> +}

Like someone already noticed, is it really IRQ number you would like to return?

If you rewrite like

int irq;

if (IS_ENABLED(...)) {
irq = ...
if (irq < 0)
return irq;

... = irq;

}

return 0;

It would be slightly more explicit what you do and what you return.

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2018-07-11 09:24    [W:0.037 / U:11.184 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site