lkml.org 
[lkml]   [2018]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v9 5/7] tracing: Centralize preemptirq tracepoints and unify their usage
On Wed, 11 Jul 2018 09:19:44 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Wed, 11 Jul 2018 15:12:56 +0200
> Peter Zijlstra <peterz@infradead.org> wrote:
>
> > On Thu, Jun 28, 2018 at 11:21:47AM -0700, Joel Fernandes wrote:
> > > One note, I have to check for lockdep recursion in the code that calls
> > > the trace events API and bail out if we're in lockdep recursion
> >
> > I'm not seeing any new lockdep_recursion checks...
>
> I believe he's talking about this part:
>
> +void trace_hardirqs_on(void)
> +{
> + if (lockdep_recursing(current) || !this_cpu_read(tracing_irq_cpu))
> + return;
> +

And the reason he said this is new, IIUC, is because the old way we
could still do irqsoff tracing even if lockdep_recursion is set. Now,
irqsoff tracing is disable within lockdep_recursion.

-- Steve

\
 
 \ /
  Last update: 2018-07-11 15:23    [W:0.076 / U:38.780 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site