Messages in this thread | | | Date | Tue, 10 Jul 2018 17:41:01 +0800 | From | kbuild test robot <> | Subject | Re: [PATCH] locking/rwsem: Convert the other sem->count to 'atomic_long_t' |
| |
Hi Tetsuo,
I love your patch! Perhaps something to improve:
[auto build test WARNING on tip/locking/core] [also build test WARNING on v4.18-rc4 next-20180709] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Tetsuo-Handa/locking-rwsem-Convert-the-other-sem-count-to-atomic_long_t/20180710-141553 config: m68k-m5475evb_defconfig (attached as .config) compiler: m68k-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.2.0 make.cross ARCH=m68k
All warnings (new ones prefixed by >>):
In file included from include/linux/notifier.h:15:0, from include/linux/memory_hotplug.h:7, from include/linux/mmzone.h:777, from include/linux/gfp.h:6, from include/linux/idr.h:16, from include/linux/kernfs.h:14, from include/linux/sysfs.h:16, from include/linux/kobject.h:20, from include/linux/pci.h:29, from drivers//pci/search.c:11: include/linux/rwsem.h:87:2: warning: missing braces around initializer [-Wmissing-braces] { __RWSEM_INIT_COUNT(name), \ ^ include/linux/rwsem.h:94:29: note: in expansion of macro '__RWSEM_INITIALIZER' struct rw_semaphore name = __RWSEM_INITIALIZER(name) ^~~~~~~~~~~~~~~~~~~ >> drivers//pci/search.c:17:1: note: in expansion of macro 'DECLARE_RWSEM' DECLARE_RWSEM(pci_bus_sem); ^~~~~~~~~~~~~
vim +/DECLARE_RWSEM +17 drivers//pci/search.c
^1da177e Linus Torvalds 2005-04-16 @11 #include <linux/pci.h> 5a0e3ad6 Tejun Heo 2010-03-24 12 #include <linux/slab.h> ^1da177e Linus Torvalds 2005-04-16 13 #include <linux/module.h> ^1da177e Linus Torvalds 2005-04-16 14 #include <linux/interrupt.h> ^1da177e Linus Torvalds 2005-04-16 15 #include "pci.h" ^1da177e Linus Torvalds 2005-04-16 16 d71374da Zhang Yanmin 2006-06-02 @17 DECLARE_RWSEM(pci_bus_sem); ce29ca3e Amos Kong 2012-05-23 18 EXPORT_SYMBOL_GPL(pci_bus_sem); ce29ca3e Amos Kong 2012-05-23 19
:::::: The code at line 17 was first introduced by commit :::::: d71374dafbba7ec3f67371d3b7e9f6310a588808 [PATCH] PCI: fix race with pci_walk_bus and pci_destroy_dev
:::::: TO: Zhang Yanmin <yanmin.zhang@intel.com> :::::: CC: Greg Kroah-Hartman <gregkh@suse.de>
--- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation [unhandled content-type:application/gzip] | |