lkml.org 
[lkml]   [2018]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v6 6/8] interconnect: qcom: Add msm8916 interconnect provider driver
    On Mon, Jul 9, 2018 at 8:51 AM Georgi Djakov <georgi.djakov@linaro.org> wrote:
    >
    > Add driver for the Qualcomm interconnect buses found in msm8916 based
    > platforms.
    >
    > Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
    > ---
    > drivers/interconnect/Kconfig | 5 +
    > drivers/interconnect/Makefile | 1 +
    > drivers/interconnect/qcom/Kconfig | 10 +
    > drivers/interconnect/qcom/Makefile | 2 +
    > drivers/interconnect/qcom/msm8916.c | 499 ++++++++++++++++++++++++++++
    > 5 files changed, 517 insertions(+)
    > create mode 100644 drivers/interconnect/qcom/msm8916.c
    >
    > diff --git a/drivers/interconnect/Kconfig b/drivers/interconnect/Kconfig
    > index a261c7d41deb..07a8276fa35a 100644
    > --- a/drivers/interconnect/Kconfig
    > +++ b/drivers/interconnect/Kconfig
    > @@ -8,3 +8,8 @@ menuconfig INTERCONNECT
    >
    > If unsure, say no.
    >
    > +if INTERCONNECT
    > +
    > +source "drivers/interconnect/qcom/Kconfig"
    > +
    > +endif
    > diff --git a/drivers/interconnect/Makefile b/drivers/interconnect/Makefile
    > index 97fca2e09d24..7944cbca0527 100644
    > --- a/drivers/interconnect/Makefile
    > +++ b/drivers/interconnect/Makefile
    > @@ -1,2 +1,3 @@
    > # SPDX-License-Identifier: GPL-2.0
    > obj-$(CONFIG_INTERCONNECT) += core.o
    > +obj-$(CONFIG_INTERCONNECT_QCOM) += qcom/
    > diff --git a/drivers/interconnect/qcom/Kconfig b/drivers/interconnect/qcom/Kconfig
    > index b0c2ff928d88..a87afdef1bf7 100644
    > --- a/drivers/interconnect/qcom/Kconfig
    > +++ b/drivers/interconnect/qcom/Kconfig
    > @@ -2,6 +2,8 @@ config INTERCONNECT_QCOM
    > bool "Qualcomm Network-on-Chip interconnect drivers"
    > depends on INTERCONNECT
    > depends on ARCH_QCOM || COMPILE_TEST
    > + help
    > + Support for Qualcomm's Network-on-Chip interconnect hardware.
    >
    > config INTERCONNECT_QCOM_SMD_RPM
    > tristate "Qualcomm SMD RPM interconnect driver"
    > @@ -9,3 +11,11 @@ config INTERCONNECT_QCOM_SMD_RPM
    > help
    > This is a driver for communicating interconnect related configuration
    > details with a remote processor (RPM) on Qualcomm platforms.
    > +
    > +config INTERCONNECT_QCOM_MSM8916
    > + tristate "Qualcomm MSM8916 interconnect driver"
    > + depends on INTERCONNECT_QCOM
    > + select INTERCONNECT_QCOM_SMD_RPM

    I'm not a kconfig expert, maybe someone else could chime in. I have
    this impression that folks don't like select. Is there a way to do
    this with depends instead? If I'm way off here, ignore me.

    \
     
     \ /
      Last update: 2018-07-11 00:41    [W:6.483 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site