lkml.org 
[lkml]   [2018]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.17 055/220] soc: rockchip: power-domain: Fix wrong value when power up pd with writemask
    Date
    4.17-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Finley Xiao <finley.xiao@rock-chips.com>

    commit 9e59c5f66c624b43c766a9fe3b2430e0e976bf0e upstream.

    Solve the pd could only ever turn off but never turn them on again,
    if the pd registers have the writemask bits.

    So far this affects the rk3328 only.

    Fixes: 79bb17ce8edb ("soc: rockchip: power-domain: Support domain control in hiword-registers")
    Cc: stable@vger.kernel.org
    Signed-off-by: Finley Xiao <finley.xiao@rock-chips.com>
    Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com>
    Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
    Signed-off-by: Heiko Stuebner <heiko@sntech.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/soc/rockchip/pm_domains.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/soc/rockchip/pm_domains.c
    +++ b/drivers/soc/rockchip/pm_domains.c
    @@ -255,7 +255,7 @@ static void rockchip_do_pmu_set_power_do
    return;
    else if (pd->info->pwr_w_mask)
    regmap_write(pmu->regmap, pmu->info->pwr_offset,
    - on ? pd->info->pwr_mask :
    + on ? pd->info->pwr_w_mask :
    (pd->info->pwr_mask | pd->info->pwr_w_mask));
    else
    regmap_update_bits(pmu->regmap, pmu->info->pwr_offset,

    \
     
     \ /
      Last update: 2018-07-01 19:19    [W:4.404 / U:0.256 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site