Messages in this thread | | | Subject | Re: [PATCH] scsi: ipr: fix build on 32-bit architectures | From | Sinan Kaya <> | Date | Fri, 8 Jun 2018 15:39:23 -0400 |
| |
On 6/8/2018 3:20 PM, Brian King wrote: >> I don't think there is a consensus about using these includes in the community. >> I bumped into this issue before and came up with an include you pointed. >> I didn't get too much enthusiasm from the maintainer. >> >> Why are we pushing the responsibility into the drivers? I'd think that architecture >> should take care of this. Is there a portability issue that I'm missing from some >> architecture I never heart of? (I work on Little-Endian machines most of the time) > The attributes of the adapter hardware can have an impact here. The ipr hardware, for > example, depends on the upper 4 bytes to be written first, then the lower 4 bytes > to be written second, and its the act of writing the lower 4 bytes that triggers > the adapter hardware to read the value and take action on it.
Thanks, I never thought about this.
-- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
| |