lkml.org 
[lkml]   [2018]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 09/10] perf/cputime: Don't stop idle tick if there's live cputime event
Hi Jiri,

On Thu, Jun 7, 2018 at 8:45 AM Andi Kleen <andi@firstfloor.org> wrote:
>
> On Thu, Jun 07, 2018 at 12:15:12AM +0200, Jiri Olsa wrote:
> > Disable stopping of the idle tick when having live cputime
> > event. When the tick is disabled, the idle counts are out
> > of date until next tick/update and perf cputime PMU provides
> > misleading counts.
>
> I really don't like this. This can totally change performance
> (e.g. less Turbo due to less idle) and performance tools shouldn't
> change the performance profile drastically.
>
You do not want to change the behavior of the kernel just because you
are monitoring.
This may introduce side effects on other events which may not otherwise exist.

\
 
 \ /
  Last update: 2018-06-07 18:02    [W:0.127 / U:0.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site