lkml.org 
[lkml]   [2018]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 130/410] console/dummy: leave .con_font_get set to NULL
    3.16.57-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Nicolas Pitre <nicolas.pitre@linaro.org>

    commit 724ba8b30b044aa0d94b1cd374fc15806cdd6f18 upstream.

    When this method is set, the caller expects struct console_font fields
    to be properly initialized when it returns. Leave it unset otherwise
    nonsensical (leaked kernel stack) values are returned to user space.

    Signed-off-by: Nicolas Pitre <nico@linaro.org>
    Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/video/console/dummycon.c | 1 -
    1 file changed, 1 deletion(-)

    --- a/drivers/video/console/dummycon.c
    +++ b/drivers/video/console/dummycon.c
    @@ -71,7 +71,6 @@ const struct consw dummy_con = {
    .con_switch = DUMMY,
    .con_blank = DUMMY,
    .con_font_set = DUMMY,
    - .con_font_get = DUMMY,
    .con_font_default = DUMMY,
    .con_font_copy = DUMMY,
    .con_set_palette = DUMMY,
    \
     
     \ /
      Last update: 2018-06-07 17:56    [W:6.086 / U:0.144 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site