lkml.org 
[lkml]   [2018]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 217/410] cifs: silence compiler warnings showing up with gcc-8.0.0
    3.16.57-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Arnd Bergmann <arnd@arndb.de>

    commit ade7db991b47ab3016a414468164f4966bd08202 upstream.

    This bug was fixed before, but came up again with the latest
    compiler in another function:

    fs/cifs/cifssmb.c: In function 'CIFSSMBSetEA':
    fs/cifs/cifssmb.c:6362:3: error: 'strncpy' offset 8 is out of the bounds [0, 4] [-Werror=array-bounds]
    strncpy(parm_data->list[0].name, ea_name, name_len);

    Let's apply the same fix that was used for the other instances.

    Fixes: b2a3ad9ca502 ("cifs: silence compiler warnings showing up with gcc-4.7.0")
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    Signed-off-by: Steve French <smfrench@gmail.com>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    fs/cifs/cifssmb.c | 4 +---
    1 file changed, 1 insertion(+), 3 deletions(-)

    --- a/fs/cifs/cifssmb.c
    +++ b/fs/cifs/cifssmb.c
    @@ -6366,9 +6366,7 @@ SetEARetry:
    pSMB->InformationLevel =
    cpu_to_le16(SMB_SET_FILE_EA);

    - parm_data =
    - (struct fealist *) (((char *) &pSMB->hdr.Protocol) +
    - offset);
    + parm_data = (void *)pSMB + offsetof(struct smb_hdr, Protocol) + offset;
    pSMB->ParameterOffset = cpu_to_le16(param_offset);
    pSMB->DataOffset = cpu_to_le16(offset);
    pSMB->SetupCount = 1;
    \
     
     \ /
      Last update: 2018-06-07 17:53    [W:3.617 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site