lkml.org 
[lkml]   [2018]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 137/410] NFS: commit direct writes even if they fail partially
    3.16.57-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: "J. Bruce Fields" <bfields@redhat.com>

    commit 1b8d97b0a837beaf48a8449955b52c650a7114b4 upstream.

    If some of the WRITE calls making up an O_DIRECT write syscall fail,
    we neglect to commit, even if some of the WRITEs succeed.

    We also depend on the commit code to free the reference count on the
    nfs_page taken in the "if (request_commit)" case at the end of
    nfs_direct_write_completion(). The problem was originally noticed
    because ENOSPC's encountered partway through a write would result in a
    closed file being sillyrenamed when it should have been unlinked.

    Signed-off-by: J. Bruce Fields <bfields@redhat.com>
    Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
    [bwh: Backported to 3.16: adjust context]
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    fs/nfs/direct.c | 4 +---
    1 file changed, 1 insertion(+), 3 deletions(-)

    --- a/fs/nfs/direct.c
    +++ b/fs/nfs/direct.c
    @@ -732,10 +732,8 @@ static void nfs_direct_write_completion(

    spin_lock(&dreq->lock);

    - if (test_bit(NFS_IOHDR_ERROR, &hdr->flags)) {
    - dreq->flags = 0;
    + if (test_bit(NFS_IOHDR_ERROR, &hdr->flags))
    dreq->error = hdr->error;
    - }
    if (dreq->error != 0)
    bit = NFS_IOHDR_ERROR;
    else {
    \
     
     \ /
      Last update: 2018-06-07 17:26    [W:4.022 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site