lkml.org 
[lkml]   [2018]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 403/410] ALSA: pcm: potential uninitialized return values
    3.16.57-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit 5607dddbfca774fb38bffadcb077fe03aa4ac5c6 upstream.

    Smatch complains that "tmp" can be uninitialized if we do a zero size
    write.

    Fixes: 02a5d6925cd3 ("ALSA: pcm: Avoid potential races between OSS ioctls and read/write")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    sound/core/oss/pcm_oss.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/sound/core/oss/pcm_oss.c
    +++ b/sound/core/oss/pcm_oss.c
    @@ -1362,7 +1362,7 @@ static ssize_t snd_pcm_oss_write2(struct
    static ssize_t snd_pcm_oss_write1(struct snd_pcm_substream *substream, const char __user *buf, size_t bytes)
    {
    size_t xfer = 0;
    - ssize_t tmp;
    + ssize_t tmp = 0;
    struct snd_pcm_runtime *runtime = substream->runtime;

    if (atomic_read(&substream->mmap_count))
    @@ -1469,7 +1469,7 @@ static ssize_t snd_pcm_oss_read2(struct
    static ssize_t snd_pcm_oss_read1(struct snd_pcm_substream *substream, char __user *buf, size_t bytes)
    {
    size_t xfer = 0;
    - ssize_t tmp;
    + ssize_t tmp = 0;
    struct snd_pcm_runtime *runtime = substream->runtime;

    if (atomic_read(&substream->mmap_count))
    \
     
     \ /
      Last update: 2018-06-07 17:03    [W:4.080 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site