lkml.org 
[lkml]   [2018]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/4] watchdog/softlockup: Replace "watchdog/%u" threads with cpu_stop_work
On Thu, Jun 07, 2018 at 02:33:12PM +0200, Peter Zijlstra wrote:

> +static int softlockup_stop_fn(void *data)
> {
> + watchdog_disable(smp_processor_id());
> + return 0;
> }
>
> +static void softlockup_stop_all(void)
> {
> + int cpu;
> +
> + for_each_cpu(cpu, &watchdog_allowed_mask)
> + stop_one_cpu(cpu, softlockup_stop_fn, NULL);
> +
> + cpumask_clear(&watchdog_allowed_mask);
> }

Bugger, that one doesn't quite work.. watchdog_disable() ends up calling
a sleeping function. I forgot to enable all the debug cruft when
testing..

Let me try and fix that..

\
 
 \ /
  Last update: 2018-06-07 16:25    [W:0.086 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site