lkml.org 
[lkml]   [2018]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 384/410] RDMA/ucma: Correct option size check using optlen
    3.16.57-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Chien Tin Tung <chien.tin.tung@intel.com>

    commit 5f3e3b85cc0a5eae1c46d72e47d3de7bf208d9e2 upstream.

    The option size check is using optval instead of optlen
    causing the set option call to fail. Use the correct
    field, optlen, for size check.

    Fixes: 6a21dfc0d0db ("RDMA/ucma: Limit possible option size")
    Signed-off-by: Chien Tin Tung <chien.tin.tung@intel.com>
    Signed-off-by: Shiraz Saleem <shiraz.saleem@intel.com>
    Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
    Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/infiniband/core/ucma.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/infiniband/core/ucma.c
    +++ b/drivers/infiniband/core/ucma.c
    @@ -1200,7 +1200,7 @@ static ssize_t ucma_set_option(struct uc
    if (IS_ERR(ctx))
    return PTR_ERR(ctx);

    - if (unlikely(cmd.optval > KMALLOC_MAX_SIZE))
    + if (unlikely(cmd.optlen > KMALLOC_MAX_SIZE))
    return -EINVAL;

    optval = memdup_user((void __user *) (unsigned long) cmd.optval,
    \
     
     \ /
      Last update: 2018-06-07 16:12    [W:2.195 / U:0.536 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site