lkml.org 
[lkml]   [2018]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v5 01/14] mfd: da9063: Replace regmap_add_irq_chip with devm counterpart
    On Thu, 07 Jun 2018, Marek Vasut wrote:

    > On 06/06/2018 11:59 AM, Marek Vasut wrote:
    > > Use devm_regmap_add_irq_chip() instead of plain regmap_add_irq_chip(),
    > > which removes the need for da9063_irq_exit() altogether and also
    > > fixes a bug in da9063_device_init() where the da9063_irq_exit() was
    > > not called in a failpath.
    > >
    > > Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
    > > Cc: Geert Uytterhoeven <geert+renesas@glider.be>
    > > Cc: Lee Jones <lee.jones@linaro.org>
    > > Cc: Mark Brown <broonie@kernel.org>
    > > Cc: Steve Twiss <stwiss.opensource@diasemi.com>
    > > Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>
    > > Cc: linux-renesas-soc@vger.kernel.org
    >
    > So it's just this one patch that's missing AB/RB and the series should
    > be good?

    Looks fine. Although we'll let it sit for a while in case anyone else
    has any thoughts.

    The merge window is currently open, so there is no rush to apply.

    > > ---
    > > V5: New patch
    > > ---
    > > drivers/mfd/da9063-core.c | 1 -
    > > drivers/mfd/da9063-irq.c | 8 ++------
    > > include/linux/mfd/da9063/core.h | 1 -
    > > 3 files changed, 2 insertions(+), 8 deletions(-)

    For my own reference:
    Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>

    --
    Lee Jones [李琼斯]
    Linaro Services Technical Lead
    Linaro.org │ Open source software for ARM SoCs
    Follow Linaro: Facebook | Twitter | Blog

    \
     
     \ /
      Last update: 2018-06-07 14:42    [W:4.788 / U:0.124 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site