lkml.org 
[lkml]   [2018]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 5/7] x86: Insert endbr32/endbr64 to vDSO
On Thu, Jun 7, 2018 at 4:00 PM, Andy Lutomirski <luto@kernel.org> wrote:
> On Thu, Jun 7, 2018 at 3:03 PM H.J. Lu <hjl.tools@gmail.com> wrote:
>>
>> On Thu, Jun 7, 2018 at 1:50 PM, Andy Lutomirski <luto@kernel.org> wrote:
>> > On Thu, Jun 7, 2018 at 7:42 AM Yu-cheng Yu <yu-cheng.yu@intel.com> wrote:
>> >>
>> >> From: "H.J. Lu" <hjl.tools@gmail.com>
>> >>
>> >> When Intel indirect branch tracking is enabled, functions in vDSO which
>> >> may be called indirectly should have endbr32 or endbr64 as the first
>> >> instruction. We try to compile vDSO with -fcf-protection=branch -mibt
>> >> if possible. Otherwise, we insert endbr32 or endbr64 by hand to assembly
>> >> codes generated by the compiler.
>> >
>> > Wow, that's... a genuine abomination. Do we really need to support
>> > CET on kernels built with old toolchains?
>> >
>>
>> Yes. GCC 7 should be able to build CET kernel.
>>
>
> Why? Presumably people running distros that use CET are going to have
> kernels build with a CET-supporting compiler.
>

Good point. It was needed before GCC 8 was released. We can drop
arch/x86/entry/vdso/endbr.sh now.

--
H.J.

\
 
 \ /
  Last update: 2018-06-08 02:32    [W:0.044 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site