Messages in this thread | | | Date | Wed, 6 Jun 2018 16:11:30 -0700 | From | Benson Leung <> | Subject | Re: [PATCH] ACPI LID: increment wakeup count only when notified. |
| |
Hi Rafael,
On Wed, Jun 06, 2018 at 09:00:43AM +0200, Rafael J. Wysocki wrote: > > @@ -417,6 +414,7 @@ static void acpi_button_notify(struct acpi_device *device, u32 event) > > /* fall through */ > > case ACPI_BUTTON_NOTIFY_STATUS: > > input = button->input; > > + acpi_pm_wakeup_event(&device->dev); > > Not really. > > There already is an acpi_pm_wakeup_event() call in the else branch below. >
Ravi removes that other call below. The intent for this is to call acpi_pm_wakeup_event() regardless if the button->type is ACPI_BUTTON_TYPE_LID, in case that event is ACPI_BUTTON_NOTIFY_STATUS.
> > if (button->type == ACPI_BUTTON_TYPE_LID) { > > mutex_lock(&button->input->mutex); > > users = button->input->users; > > @@ -426,7 +424,6 @@ static void acpi_button_notify(struct acpi_device *device, u32 event) > > } else { > > int keycode; > > > > - acpi_pm_wakeup_event(&device->dev); > > if (button->suspended) > > break; > > > > --
Thanks! Benson -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. bleung@google.com Chromium OS Project bleung@chromium.org [unhandled content-type:application/pgp-signature] | |