Messages in this thread | | | Date | Wed, 06 Jun 2018 14:01:35 -0400 (EDT) | Subject | Re: [PATCH] bnx2x: use the right constant | From | David Miller <> |
| |
From: Julia Lawall <Julia.Lawall@lip6.fr> Date: Wed, 6 Jun 2018 15:03:22 +0200
> Nearby code that also tests port suggests that the P0 constant should be > used when port is zero. > > The semantic match that finds this problem is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > expression e,e1; > @@ > > * e ? e1 : e1 > // </smpl> > > Fixes: 6c3218c6f7e5 ("bnx2x: Adjust ETS to 578xx") > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
This definitely looks correct. Applied and queued up for -stable, thanks!
| |